Thank you for your contribution 👍

In order to accept your changes please be sure to sure to sign the eclipse contributor agreement (eca) with the same email as your authorship.

I'm not sure I fully understand the reasons for the change, it is only updating the variable name in the callback, uses of MessagingContribution.push still use channel (verified with find all references).

The original channel param name is misunderstanding with the channel concept in MessagingContribution.handleChannels method, but actually it means socket.

The original channel param name is misunderstanding with the channel concept in MessagingContribution.handleChannels method, but actually it means socket.

I believe socket might also be confusing since it accepts any generic connection (likely the best name).
Currently we have WebSocketChannel and Socket that make use of ConnectionHandlers:

so, if this is meaningful:

push(spec: string, callback: (params: MessagingService.PathParams, connection: T) => void): void {
    const route = new Route(spec);
    // here is the change, or you can look at the lastest changes.
    this.handlers.push((path, channel: T) => {
        const params = route.match(path);
        if (!params) {
            return false;
        }
        callback(params, channel);
        return route.reverse(params);
    });
}